Fix wasm-bindgen if lib is renamed via lib.name
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where if a library is renamed via the `name` key in the `[lib]` section of the manifest then `wasm-pack` would try to generate bindings for an noexistent wasm-file, generating an error. The fix was to internally use `cargo_metadata` more aggressively and move around where this data is generated. This ended up refactoring a few locations, but this should also bring improved error messages for `cargo metadata` as well as caching the resulting data more aggressively to avoid recalculating it too much. Closes rustwasm#339
alexcrichton
force-pushed
the
handle-rename
branch
from
1572a16
to
35fe250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where if a library is renamed via the
namekey in the
[lib]section of the manifest thenwasm-packwould try togenerate bindings for an noexistent wasm-file, generating an error.
The fix was to internally use
cargo_metadatamore aggressively andmove around where this data is generated. This ended up refactoring a
few locations, but this should also bring improved error messages for
cargo metadataas well as caching the resulting data more aggressivelyto avoid recalculating it too much.
Closes #339