Use a global cache for all downloaded binaries #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches wasm-pack to using a global cache for all download binaries, living typically in a user's home directory. The intention here is to aovid creating a `bin` folder in all wasm-pack projects and additionally share downloads between projects to ensure that you're downloading a minimal number of binaries from the network. Along the way the downloading code was restructured to support a global cache, but everything should largely be as it was before! Closes rustwasm#292
alexcrichton
force-pushed
the
home-dir-cache
branch
from
26d06f0
to
c664cfd
Compare
Add message assertions to the various assertions in `test.rs`
In `wasm-pack` it can't do cross-process synchronization, and in tests there's now multiple processes which need to be synchronized.
alexcrichton
force-pushed
the
home-dir-cache
branch
from
af53bf8
to
f986edf
Compare
fitzgen
approved these changes
Nov 5, 2018
| } | ||
|
|
||
| // Run `cargo install` to a temporary location to handle ctrl-c gracefully | ||
| // and ensure we don't accidentally use stale files in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches wasm-pack to using a global cache for all download
binaries, living typically in a user's home directory. The intention
here is to aovid creating a
binfolder in all wasm-pack projects andadditionally share downloads between projects to ensure that you're
downloading a minimal number of binaries from the network.
Along the way the downloading code was restructured to support a global
cache, but everything should largely be as it was before!
Closes #292