Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-modules to --target flag's help text #417

Merged
merged 7 commits into from
Oct 30, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Oct 23, 2018

Fixes #416

@ashleygwilliams
Copy link
Member

test result: ok. 34 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
   Doc-tests wasm-pack
error[E0460]: found possibly newer version of crate `itoa` which `cargo_metadata` depends on
 --> C:\projects\wasm-pack-071k0\src\lib.rs:5:1
  |
5 | extern crate cargo_metadata;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: perhaps that crate needs to be recompiled?
  = note: the following crate versions were found:
          crate `itoa`: \\?\C:\projects\wasm-pack-071k0\target\release\deps\libitoa-cb012311ce8053ac.rlib
          crate `cargo_metadata`: \\?\C:\projects\wasm-pack-071k0\target\release\deps\libcargo_metadata-dc42b0938c512d43.rlib
error: test failed, to rerun pass '--doc'
Command exited with code 1

appveyor is failing because of this. maybe a cargo update would help? not sure what's happening here exactly, would need to dig into those specific deps

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we are green this is good to go.

@fitzgen
Copy link
Member Author

fitzgen commented Oct 23, 2018

Did a carog update and hopefully that will fix the issue

@ashleygwilliams
Copy link
Member

looks like it didn't :/ you also need a cargo fmt fyi

@fitzgen
Copy link
Member Author

fitzgen commented Oct 24, 2018

@alexcrichton says this is a compiler/cargo bug somewhere and that we should pin to a nightly from a couple days ago until he has a chance to investigate further.

@ashleygwilliams
Copy link
Member

this seems to be still failing- do we have a sense as to why? i'm still not clear on the original error, entirely.

@fitzgen
Copy link
Member Author

fitzgen commented Oct 29, 2018

It is a cargo bug that we are waiting on a fix for -- all I did was rebase to keep up with changes.

@alexcrichton
Copy link
Contributor

What might be happening here is something like this:

  • Wasm-pack is built
  • Wasm-pack's tests then run
  • Some of wasm-pack's test build further things with Cargo. These compilations share the same target directory as wasm-pack itself. These compilations then overwrite and/or recompile libraries in-place
  • Later when doctests run the newer libraries cause issues because libraries depending on them aren't rebuilt.

I haven't confirmed this yet locally, but that's my suspicion at this time. Looking through the history we see this is the first failing build which is connected to this PR which does seem to be adding tests which build more things. Maybe that test could be temporarily commented out to see if it passes?

@fitzgen
Copy link
Member Author

fitzgen commented Oct 30, 2018

Running the tests with --test-threads 1 does not seem to solve the problem.

@fitzgen fitzgen added this to the 0.6.0 milestone Oct 30, 2018
@fitzgen
Copy link
Member Author

fitzgen commented Oct 30, 2018

Running cargo test --tests and cargo test --doc separately seems to do the trick.

@fitzgen fitzgen merged commit 9218c65 into rustwasm:master Oct 30, 2018
@fitzgen fitzgen deleted the issue-416 branch October 30, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants