-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-modules to --target flag's help text #417
Conversation
appveyor is failing because of this. maybe a cargo update would help? not sure what's happening here exactly, would need to dig into those specific deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once we are green this is good to go.
Did a |
looks like it didn't :/ you also need a cargo fmt fyi |
@alexcrichton says this is a compiler/cargo bug somewhere and that we should pin to a nightly from a couple days ago until he has a chance to investigate further. |
this seems to be still failing- do we have a sense as to why? i'm still not clear on the original error, entirely. |
It is a cargo bug that we are waiting on a fix for -- all I did was rebase to keep up with changes. |
What might be happening here is something like this:
I haven't confirmed this yet locally, but that's my suspicion at this time. Looking through the history we see this is the first failing build which is connected to this PR which does seem to be adding tests which build more things. Maybe that test could be temporarily commented out to see if it passes? |
Running the tests with |
Running |
Fixes #416