Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit_status to cli error to fix #291 #387

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

konstin
Copy link
Contributor

@konstin konstin commented Oct 1, 2018

fixes #291

Example output:

  [1/9] Checking `rustc` version...
  [2/9] Checking crate configuration...
  [3/9] Adding WASM target...
| [4/9] Compiling to WASM...
Process exited with exit code: 101: Compilation of your program failed. stderr:

   Compiling a v0.1.0 (/home/konsti/wasm-pack/a)
error[E0425]: cannot find function `fail` in this scope
 --> src/lib.rs:3:5
  |
3 |     fail();
  |     ^^^^ not found in this scope

error: aborting due to previous error

For more information about this error, try `rustc --explain E0425`.
error: Could not compile `a`.
  [1/9] Checking `rustc` version...
  [2/9] Checking crate configuration...
  [3/9] Adding WASM target...
/ [4/9] Compiling to WASM...
Process exited with signal: 9: Compilation of your program failed. stderr:

   Compiling lazy_static v1.1.0
   Compiling log v0.4.5
   Compiling wasm-bindgen v0.2.23
   Compiling proc-macro2 v0.4.19
   Compiling ryu v0.2.6
   Compiling serde v1.0.79

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 1, 2018
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages for spawned processes don't include exit status and/or stdout
3 participants