Copy fixtures to temp dir #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
approved these changes
Jul 14, 2018
ashleygwilliams
requested changes
Jul 14, 2018
|
Just wanted to leave a quick note that tempdir is deprecated in favor of tempfile: rust-lang-deprecated/tempdir#45 |
fitzgen
force-pushed
the
copy-fixtures-to-temp-dir
branch
5 times, most recently
from
526a8cb
to
c5b528b
Compare
|
r? @ashleygwilliams -- this should be ready for your attention again! |
3 tasks
If a test is going to do a potentially destructive operation, instead of mutating shared fixtures, it should copy the fixture to its own unique directory and then mutate that copy (doesn't this sound like Rust's borrowing and ownership rules?! ^.^)
The `tempdir` crate is deprecated and its functionality has been folded into the `tempfile` crate.
The implementation relies on the crate directory existing, and the `pkg` directory in the crate directory existing as well.
fitzgen
force-pushed
the
copy-fixtures-to-temp-dir
branch
from
c5b528b
to
abfe66c
Compare
|
Rebased! |
ashleygwilliams
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submittingYou reference which issue is being closed in the PR text✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨