Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove result prefix and std import, now that quicli is no longer a d… #193

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

SoryRawyer
Copy link
Contributor

…ependency

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Fixes #191

Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for this to pass CI before merging, but this lgtm :D

@SoryRawyer
Copy link
Contributor Author

Sorry about that! I just re-ran rustfmt and pushed the change.

@mgattozzi
Copy link
Contributor

Awesome thanks! Once that passes again I'll merge it :D

@mgattozzi mgattozzi merged commit faed391 into rustwasm:master Jun 19, 2018
@mgattozzi
Copy link
Contributor

Thanks a lot @SoryRawyer for cleaning this up! :D

@SoryRawyer
Copy link
Contributor Author

np! Thanks for reviewing + merging!

@ashleygwilliams ashleygwilliams added this to the 0.4.1 milestone Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove outdated quicli comments from init.rs
3 participants