fix: use generated binary path from cargo instead #1421
+98
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we'd invoke wasm-bindgen we'd assume that the binary we wanted
to process was `target/wasm32-unknown-unknown{debug|release}/crate.wasm`, which
isn't the case for all flags that Cargo accepts.
zebp
force-pushed
the
zeb/correct-wasm-binary
branch
from
bc4a4c6
to
ec2411c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we'd invoke wasm-bindgen we'd assume that the binary we wanted to process was
target/wasm32-unknown-unknown{debug|release}/crate.wasm, which isn't the case for all flags that Cargo accepts.My goal with this is to allow people to call
#[wasm-bindgen]functions compiled under--testsoutside ofwasm-pack testsince I'm working on a test runner for an environment not supported by wasm-pack (cloudflare workers).Fixes #1410