Don't create .gitignore in pkg directory #1408
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
Closes #984,
Closes #909
Closes #999.
Supersedes #1131, #985
Problematic Behaviour
Currently,
wasm-pack
generates a.gitignore
file in thepkg
directory during each build.Suggested Solution
This PR proposes removing the automatic creation of the
.gitignore
file without introducing a replacement.Justification
While many tools generate an appropriate
.gitignore
during project initialization, it’s relatively uncommon (in my experience) for build tools, like compilers, to create.gitignore
files during a build.Moreover, this behavior has led to several issues, as outlined in the following requests:
.gitignore
generation #728build --target web
: have an option not to add .gitignore to pkg output folder #999This PR aims to remove the generation of the problematic
.gitignore
file, addressing and potentially superseding these other PRs:Changes made