Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip optimization with wasm-opt #1321

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Add option to skip optimization with wasm-opt #1321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/command/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ pub struct Build {
pub reference_types: bool,
pub target: Target,
pub no_pack: bool,
pub no_opt: bool,
pub profile: BuildProfile,
pub mode: InstallMode,
pub out_dir: PathBuf,
Expand Down Expand Up @@ -170,6 +171,10 @@ pub struct BuildOptions {
/// Option to not generate a package.json
pub no_pack: bool,

#[clap(long = "no-opt", alias = "no-optimization")]
/// Option to skip optimization with wasm-opt
pub no_opt: bool,

/// List of extra options to pass to `cargo build`
pub extra_options: Vec<String>,
}
Expand All @@ -187,6 +192,7 @@ impl Default for BuildOptions {
debug: false,
dev: false,
no_pack: false,
no_opt: false,
release: false,
profiling: false,
out_dir: String::new(),
Expand Down Expand Up @@ -232,6 +238,7 @@ impl Build {
reference_types: build_opts.reference_types,
target: build_opts.target,
no_pack: build_opts.no_pack,
no_opt: build_opts.no_opt,
profile,
mode: build_opts.mode,
out_dir,
Expand All @@ -249,7 +256,7 @@ impl Build {

/// Execute this `Build` command.
pub fn run(&mut self) -> Result<()> {
let process_steps = Build::get_process_steps(self.mode, self.no_pack);
let process_steps = Build::get_process_steps(self.mode, self.no_pack, self.no_opt);

let started = Instant::now();

Expand All @@ -274,7 +281,11 @@ impl Build {
Ok(())
}

fn get_process_steps(mode: InstallMode, no_pack: bool) -> Vec<(&'static str, BuildStep)> {
fn get_process_steps(
mode: InstallMode,
no_pack: bool,
no_opt: bool,
) -> Vec<(&'static str, BuildStep)> {
macro_rules! steps {
($($name:ident),+) => {
{
Expand Down Expand Up @@ -302,9 +313,12 @@ impl Build {
step_create_dir,
step_install_wasm_bindgen,
step_run_wasm_bindgen,
step_run_wasm_opt,
]);

if !no_opt {
steps.extend(steps![step_run_wasm_opt]);
}

if !no_pack {
steps.extend(steps![
step_create_json,
Expand Down
Loading