Add option to skip optimization with wasm-opt #1321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently running
wasm-pack
three times for our project. Once for the main-thread wasm file, once for the web-worker wasm file, and once to generate types that include both of those builds.This
--no-opt
option would help me immensely by reducing our build time by ~30% by not having to wait for thewasm-opt
step for the type generation. I cannot disablewasm-opt
generally inCargo.toml
, because I still want it for the other two actual build steps.An alternative to this PR would be a
--types-only
option, which only outputs a .d.ts file.rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨