Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting the target-dir in wasm_bindgen_build #1279

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Fix getting the target-dir in wasm_bindgen_build #1279

merged 2 commits into from
Jun 11, 2023

Conversation

tomasol
Copy link
Contributor

@tomasol tomasol commented Apr 29, 2023 •
edited
Loading

Fixes #1278

The bug was caused by using binary_search on extra_options which is not sorted.

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

ranile
ranile reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this as well?

@tomasol tomasol force-pushed the fix-target-dir-in-bindgen branch from e3a5284 to 4190e54 Compare May 30, 2023 16:26
@tomasol
Copy link
Contributor Author

tomasol commented May 30, 2023

Can you add a test case for this as well?

@hamza1311 sure, I've added a test that panics on current master 3073db8 .

ranile
ranile approved these changes Jun 1, 2023 •
edited
Loading
View reviewed changes
ranile
ranile reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't mean to approve. The CI is failing

@tomasol
Copy link
Contributor Author

tomasol commented Jun 1, 2023

I have seen the same failure in other actions as well, e.g. here
There is nothing in this PR changing the log levels. Master is broken as well.

drager
drager approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit 5293380 into rustwasm:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranile ranile ranile approved these changes

@drager drager drager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when --target-dir is supplied
3 participants
@tomasol @drager @ranile