Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JamesIves/github-pages-deploy-action in GHA workflow to v4.4.1 #1223

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Update JamesIves/github-pages-deploy-action in GHA workflow to v4.4.1 #1223

merged 1 commit into from
Mar 19, 2023

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Feb 4, 2023

Updates the JamesIves/github-pages-deploy-action action used in the GitHub Actions workflow to its newest version.

Still using an older version of JamesIves/github-pages-deploy-action will generate some warning like in this run: https://github.com/rustwasm/wasm-pack/actions/runs/4032230808

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2, JamesIves/github-pages-deploy-action@4.1.4. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The PR will get rid of those warnings for JamesIves/github-pages-deploy-action, because v4.4.1 uses Node.js 16.

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drager drager merged commit 73e7c3d into rustwasm:master Mar 19, 2023
@striezel striezel deleted the github-pages-deploy-action-update branch March 20, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants