Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasm-opt to version 108. #1136

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented May 13, 2022

Bump wasm-opt to version 108. Solves performance issues caused by the outdated version ()

Closes #1135.

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

@wdanilo
Copy link

wdanilo commented May 13, 2022

@drager would you be so nice to merge it? This change saves tons of time for our team (shortens wasm-opt from 3-5 minutes to a few seconds on some systems). See the linked ticket to learn more about why.

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drager drager merged commit 74fac79 into rustwasm:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled wasm-opt performance really, bad.
3 participants