Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-pack provides no output when its version check fails #652

Closed
sgrif opened this issue May 21, 2019 · 1 comment · Fixed by #660
Closed

wasm-pack provides no output when its version check fails #652

sgrif opened this issue May 21, 2019 · 1 comment · Fixed by #660
Labels
bug Something isn't working PR attached there's a PR open for this issue
Milestone
0.9.0

Comments

@sgrif
Copy link

sgrif commented May 21, 2019 •
edited
Loading

🐛 Bug description

When wasm-pack checks to see if a more recent version is released, the error is silently swallowed. Since this is an optional behavior, it makes sense to not bother the user if they're not online or something, but (as documented in #651) -- this check always fails, which has been the case for a few days, and gone unnoticed.

It's unlikely that a request to crates.io will complete with a non-200 status code, it seems reasonable to at least inform the user something happened in this case.
@drager drager mentioned this issue May 26, 2019
Merged
@drager
Copy link
Member

drager commented May 26, 2019

I think it makes sense, I submitted a fix in #660.

@ashleygwilliams ashleygwilliams added bug Something isn't working PR attached there's a PR open for this issue labels Jun 11, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working PR attached there's a PR open for this issue
Projects
None yet
Milestone
0.9.0
3 participants
@ashleygwilliams @sgrif @drager