Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting Error in Book #513

Closed
DebugSteven opened this issue Jan 18, 2019 · 1 comment · Fixed by #514
Closed

Redirecting Error in Book #513

DebugSteven opened this issue Jan 18, 2019 · 1 comment · Fixed by #514
Labels
bug Something isn't working

Comments

@DebugSteven
Copy link
Contributor

🐛 Bug description

When you click on the documentation link from the wasm pack URL, the documentation URL has the path /wasm-pack/book/. This breaks the links listed in the body of the page for Rust & NPM which are expecting a path of /wasm-pack/book/prerequisites/.

🤔 Expected Behavior

The links for Rust & NPM should be redirected to regardless of how you navigate to the prerequisites section in the wasm pack book.

👟 Steps to reproduce

Start from the repo
Click on the tutorial URL linked in the description
Click on the documentation nav-bar element
Notice the URL shows https://rustwasm.github.io/wasm-pack/book/
In the page, click the link for Rust
You are redirected to https://rustwasm.github.io/wasm-pack/book/rust.html
OR
In the page, click the link for NPM
You are redirected to https://rustwasm.github.io/wasm-pack/book/npm.html
Both result in a 404 page not found

Environment

This was on firefox 64.0.2. I think this issue is browser agnostic.

Possible Fix

I believe the code that sets the current path for the wasm pack book is here:

<a href="/wasm-pack/book">Documentation</a>

This could be possibly be changed to
<a href="/wasm-pack/book/prerequisites/">Documentation</a>
or
<a href="/wasm-pack/book/prerequisites/index.html">Documentation</a>

I tested those solutions & both seemed to work.

@ashleygwilliams ashleygwilliams added the bug Something isn't working label Jan 19, 2019
@drager
Copy link
Member

drager commented Jan 19, 2019

Thank you for this report @DebugSteven! I pushed a fix in #514 that I hope will fix this as well as some other broken links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants