Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: do not attempt to install to /usr/bin #470

Open
ishitatsuyuki opened this issue Dec 25, 2018 · 5 comments
Open

installer: do not attempt to install to /usr/bin #470

ishitatsuyuki opened this issue Dec 25, 2018 · 5 comments
Labels
bug Something isn't working installer needs discussion PR attached there's a PR open for this issue

Comments

@ishitatsuyuki
Copy link

ishitatsuyuki commented Dec 25, 2018

On Arch Linux the rustup package can be installed globally, but that doesn't mean that wasm-pack should also do so. /usr/bin/ is basically for packages only, and manually installed binaries should at least go /usr/local/bin.

Instead, we should always try to install to the Cargo binary directory when rustup is detected.

@ashleygwilliams ashleygwilliams added enhancement New feature or request help wanted Extra attention is needed question Further information is requested feature request installer labels Dec 27, 2018
@ashleygwilliams
Copy link
Member

@ishitatsuyuki - so if i am understanding correctly this is a feature request for the installer, yes? (the other way to install wasm-pack is to install it via cargo install, which is something we don't have control of here). if you can specify the exact behavior you'd want and how'd you'd accomplish it in more detail here, we can evaluate and see if it's a good fit to implement! in general- i think it sounds like a good idea! thanks :)

@ishitatsuyuki
Copy link
Author

It's more like a bug - the detection algorithm results in unwanted behavior.

The wanted behavior is to align the directory detection with cargo install, not by detecting rustup.

@Aloso
Copy link

Aloso commented Apr 14, 2019

@ashleygwilliams This is DEFINITELY a bug. For me, the init.sh script fails because the default user doesn't have write access to /usr/bin. To make it work, I have to download it and execute it with sudo!

@ashleygwilliams ashleygwilliams added bug Something isn't working and removed enhancement New feature or request feature request question Further information is requested labels Apr 14, 2019
@ashleygwilliams ashleygwilliams added this to the 0.10.0 milestone Apr 14, 2019
@dhpollack
Copy link

This is 100% a bug. There should also be a way to override the default dir.

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed PR welcome help wanted Extra attention is needed labels Jul 16, 2019
@ashleygwilliams ashleygwilliams removed this from the 0.10.0 milestone Jul 16, 2019
@windelbouwman
Copy link

I used the following command to install wasm-pack:

$ cargo install wasm-pack

No need for the installer script. The binary is installed into ~/.cargo/bin under archlinux.

Maybe the installation manual could be updated to reflect this option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working installer needs discussion PR attached there's a PR open for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants