-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make debug builds the default #437
Comments
I think there's a strong point in favor of this to match what Cargo does, having as little deviation from Cargo as possible in wasm-pack makes it more familiar to Rust developers and also makes general information about Cargo applicable to wasm-pack as well. I also think, though, that this is arguably a good point to diverge from Cargo. A fair number of users have popped up on our channels asking why code is so slow, and it often comes back to manual wasm-bindgen usage without I think I could personally go either way on this! |
Yeah me too honestly. I do feel more stronly about matching terminology, though. |
i personally think that diverging is the right choice here, but am open to being convinced otherwise. i'm glad that we switched to match terminology- do you feel like we can close this for now and revisit closer to 1.0? |
I think it's fine to take care of more pressing issues and revisit this possibly after 1.0 |
Migrated a project to wasm-pack a few days ago and I'm just now realizing that I've been using release builds the entire time. Noticed certain things that used to work (mostly things behind I'm very used to dev builds being the default so it caught be my surprise that release builds are the default. In some ways I can understand that for people new to Rust and coming in through WASM So.. for me it makes sense to be consistent with the rest of the Rust toolchain, but I can of course see that the flood of "why is my code slow!" is a concern. Potential Solution
Any downsides / challenges here? Anything that I've overlooked? Mainly just don't want someone else to feel the same confusion that I just felt to the point where I was looking up if |
Potential Solution 2Don't default to any profile and make passing in Upside being not relying on people reading stdout / downside being one extra thing that's required to get started. |
Sorry one other thing that comes to mind! I just went to go to all of the places that I use So whether or not Ok I think I'm done... cheers! |
+1 for making --dev builds by default. Release builds confuse me too. @chinedufn offered a great solution with logging. cargo build:
cargo build --release:
wasm-pack build:
wasm-pack build --debug:
Why is the last message |
cargo
does dev builds by default and we should match that behavior.We should also match the terminology: dev instead of debug.
The text was updated successfully, but these errors were encountered: