Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--out flag that allows configuration of ./pkg dir #235

Closed
xtuc opened this issue Jul 28, 2018 · 5 comments
Closed

--out flag that allows configuration of ./pkg dir #235

xtuc opened this issue Jul 28, 2018 · 5 comments
Labels
feature request help wanted Extra attention is needed PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone
0.5.0

Comments

@xtuc
Copy link
Member

xtuc commented Jul 28, 2018

This is a feature request; I would like to configure the output directory (currently hardcoded to ./pkg).

When Webpack invokes wasm-pack in the root of the project it will create the ./pkg directory. Unlike the normal wasm-pack's use case we won't publish it and don't .gitignore it.

I would like to avoid generating the intermediate files in the user's repository but rather in a temporary fs, where Webpack will be able to bundle it anyway.
@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx feature request labels Jul 28, 2018
@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Jul 28, 2018
@ashleygwilliams ashleygwilliams changed the title Allow specifying an output directory? --out flag that allows configuration of ./pkg dir Jul 28, 2018
@data-pup
Copy link
Member

I wouldn't mind taking this one! I'll start looking into it, and will follow up if I have any other questions :)

@ashleygwilliams
Copy link
Member

go for it @data-pup that'd be awesome!

@xmclark xmclark mentioned this issue Aug 23, 2018
Merged
3 tasks
@xmclark
Copy link
Contributor

xmclark commented Aug 25, 2018 •
edited
Loading

In #263, I'm pretty close to a complete solution. What should be printed here? I could imagine writing the absolute path, or trying to use a nicer looking relative path.

Additionally: there is a lot of language in the app that references "pkg". Since this may not always be the case anymore, it might be worthwhile saying "target directory" or something like that.

image

@fitzgen
Copy link
Member

fitzgen commented Aug 27, 2018

I could imagine writing the absolute path, or trying to use a nicer looking relative path.

Either one sounds good to me.

@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Sep 4, 2018
@fitzgen
Copy link
Member

fitzgen commented Sep 4, 2018

Fixed in #263

@fitzgen fitzgen closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted Extra attention is needed PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
5 participants
@fitzgen @ashleygwilliams @xmclark @xtuc @data-pup