Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split init command into init and build #188

Closed
ashleygwilliams opened this issue Jun 18, 2018 · 5 comments
Closed

split init command into init and build #188

ashleygwilliams opened this issue Jun 18, 2018 · 5 comments
Labels
help wanted Extra attention is needed PR attached there's a PR open for this issue priority question Further information is requested to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@ashleygwilliams
Copy link
Member

we've been packing (pun intended) a ton of stuff into the init command. this has the benefit of being a one-stop shop, but as we've seen with the intro of the --mode flag it's a lot harder to customize, and for those who use wasm-pack as a build tool, a single command that does everything is not really what folks want. for 0.5.0 let's break out init into a init and build command.

strawman proposal:

  • init becomes what init --mode no-build is now
  • build is everything --mode no-build skips, build should have a --no-installs flag

thoughts?

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed question Further information is requested to-do stuff that needs to happen, so plz do it k thx labels Jun 18, 2018
@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Jun 18, 2018
@ashleygwilliams
Copy link
Member Author

related: #185

@fitzgen
Copy link
Member

fitzgen commented Jun 18, 2018

SGTM.

Ideally, --no-installs will be unnecessary as well, once we can properly determine whether the dependency tools are available and up-to-date or not.

@csmoe
Copy link
Member

csmoe commented Jun 26, 2018

Given the original init options,

pub struct Init {
    crate_path: String,
    scope: Option<String>,
    disable_dts: bool,
    target: String,
    debug: bool,
    crate_name: String,
}

#194 introduced the configuration:

[package.metadata.wasm-pack.build.<build_mode>]
debug = true
features = ["console_error_panic_hook"]
rustc-opt-level = 0
wasm-opt = false
wasm-snip = false
wasm-bindgen = true

In the addition of build options above, should I move init.debug into build too?

@ashleygwilliams
Copy link
Member Author

hey @csmoe sorry i missed this comment. let me get the split done (hopefully today or tomorrow) and then we can figure out exactly where things should be. it'll be easier once it's actually in place.

@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Jul 17, 2018
@ashleygwilliams
Copy link
Member Author

closed by #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed PR attached there's a PR open for this issue priority question Further information is requested to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

No branches or pull requests

3 participants