Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't install v0.13 #1405

Open
ulvido opened this issue Jul 2, 2024 · 7 comments
Open

can't install v0.13 #1405

ulvido opened this issue Jul 2, 2024 · 7 comments

Comments

@ulvido
Copy link

ulvido commented Jul 2, 2024

🐛 Bug description

Describe your issue in detail.
cant install v0.13

🤔 Expected Behavior

What should have happened?
should install.

👟 Steps to reproduce

Clear steps describing how to reproduce the issue, including commands and flags run. If you are seeing an error, please include the full error message and stack trace.

cargo install wasm-pack

image
image

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.12.1
rustc version: 1.79.0
image

@ulvido ulvido changed the title can't install v13 can't install v0.13 Jul 2, 2024
@nulltrope
Copy link

having the same issue here, pinning to an older version in the meantime.

@byteszard
Copy link

byteszard commented Jul 3, 2024

I have the same problem on MacOS (sonoma 14.5) .

@drager
Copy link
Member

drager commented Jul 3, 2024

Hmm, I successfully installed v.0.13.0 after the release on PopOS. Investigation from the ones having problems would be much appreciated. I will also try to break the install on my system.

@ReneCode
Copy link

ReneCode commented Jul 3, 2024

on my MacOS (Sonoma 14.5)

     curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh

and

    wasm-pack build

works fine.

@nulltrope
Copy link

Hmm, I successfully installed v.0.13.0 after the release on PopOS. Investigation from the ones having problems would be much appreciated. I will also try to break the install on my system.

@drager The root of the issue seems to be that we now require cmake be installed on the host system, whereas previous versions did not require this. Simple remove cmake or spin up a new VM/container without cmake and try installing v0.13.0 to repro.

I analyzed dependency changes and it appears that v0.13.0 of this crate updated to a new version of binary-install (v0.4.0) which in turn introduced a change here rustwasm/binary-install#29 to depend on a new crate zip_next, which uses a newer version of the crate flate2.

Here's some cargo tree commands run from the latest version of wasm-pack repo (v0.13.0):

# cargo tree -i flate2
flate2 v1.0.30
└── zip v1.1.4
    └── zip_next v1.1.1
        └── binary-install v0.4.0 (*)

which in turn depends on cmake as a build dep:

# cargo tree -p flate2
flate2 v1.0.30
├── libz-ng-sys v1.1.15
│   └── libc v0.2.155
│   [build-dependencies]
│   └── cmake v0.1.50
│       └── cc v1.0.104
│           ├── jobserver v0.1.31
│           │   └── libc v0.2.155
│           ├── libc v0.2.155
│           └── once_cell v1.19.0
└── miniz_oxide v0.7.4
    └── adler v1.0.2

This is compared to the last version of the wasm-pack crate v0.12.1:

# cargo tree -i flate2
flate2 v1.0.26
└── zip v0.6.6
    └── binary-install v0.2.0 (*)

which does not depend on cmake:

# cargo tree -p flake2
flate2 v1.0.26
├── crc32fast v1.3.2
│   └── cfg-if v1.0.0
└── miniz_oxide v0.7.1
    └── adler v1.0.2

I'm also not sure zip_next is the crate you want to be using, given it's archived/deprecated in favor of the regular zip: https://crates.io/crates/zip_next.

@drager
Copy link
Member

drager commented Jul 4, 2024

Hmm, I successfully installed v.0.13.0 after the release on PopOS. Investigation from the ones having problems would be much appreciated. I will also try to break the install on my system.

@drager The root of the issue seems to be that we now require cmake be installed on the host system, whereas previous versions did not require this. Simple remove cmake or spin up a new VM/container without cmake and try installing v0.13.0 to repro.

I analyzed dependency changes and it appears that v0.13.0 of this crate updated to a new version of binary-install (v0.4.0) which in turn introduced a change here rustwasm/binary-install#29 to depend on a new crate zip_next, which uses a newer version of the crate flate2.

Here's some cargo tree commands run from the latest version of wasm-pack repo (v0.13.0):

# cargo tree -i flate2
flate2 v1.0.30
└── zip v1.1.4
    └── zip_next v1.1.1
        └── binary-install v0.4.0 (*)

which in turn depends on cmake as a build dep:

# cargo tree -p flate2
flate2 v1.0.30
├── libz-ng-sys v1.1.15
│   └── libc v0.2.155
│   [build-dependencies]
│   └── cmake v0.1.50
│       └── cc v1.0.104
│           ├── jobserver v0.1.31
│           │   └── libc v0.2.155
│           ├── libc v0.2.155
│           └── once_cell v1.19.0
└── miniz_oxide v0.7.4
    └── adler v1.0.2

This is compared to the last version of the wasm-pack crate v0.12.1:

# cargo tree -i flate2
flate2 v1.0.26
└── zip v0.6.6
    └── binary-install v0.2.0 (*)

which does not depend on cmake:

# cargo tree -p flake2
flate2 v1.0.26
├── crc32fast v1.3.2
│   └── cfg-if v1.0.0
└── miniz_oxide v0.7.1
    └── adler v1.0.2

I'm also not sure zip_next is the crate you want to be using, given it's archived/deprecated in favor of the regular zip: https://crates.io/crates/zip_next.

Ah, thank you a lot for the research. I will revert that PR and update zip to the latest version instead. Thanks!

@drager
Copy link
Member

drager commented Jul 4, 2024

Got a PR that uses binary-install v0.4.1 instead, which removes zip-next and uses latest zip instead. Now cmake etc is gone: https://github.com/rustwasm/wasm-pack/pull/1407/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eL368-L376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants