Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install script error (tiny) #1159

Closed
nuke-web3 opened this issue Jul 23, 2022 · 0 comments · Fixed by #1320
Closed

Install script error (tiny) #1159

nuke-web3 opened this issue Jul 23, 2022 · 0 comments · Fixed by #1320

Comments

@nuke-web3
Copy link

nuke-web3 commented Jul 23, 2022 •
edited
Loading 

$ curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh

sh: 139: [: x86_64: unexpected operator
info: downloading wasm-pack
info: successfully installed wasm-pack to `.../.cargo/bin/wasm-pack`

wasm-pack/docs/_installer/init.sh

Line 139 in e7d5769

if [ "$_cputype" == "aarch64" ] && [ "$_ostype" == "apple-darwin" ]; then

On Pop!_OS 22.04 LTS

No error in bash , but the curl uses sh (rightly so IMHO)
@nuke-web3 nuke-web3 mentioned this issue Jul 23, 2022
Closed
astraw added a commit to colorimetry/colorimetry-net that referenced this issue Sep 24, 2022
@astraw
wasm-pack install requires bash
4d183cb 
See rustwasm/wasm-pack#1159 (fixed in
rustwasm/wasm-pack#1160 but this is not released
yet).
astraw added a commit to astraw/bui-backend that referenced this issue Sep 29, 2022
@astraw
wasm-pack installer depends on bash, not sh
86bd8dc 
See rustwasm/wasm-pack#1159
@socketbox socketbox mentioned this issue Apr 23, 2023
Closed
lucashorward added a commit to lucashorward/wasm-pack that referenced this issue Aug 7, 2023
@lucashorward
Fix error and warnings in install script
afb63e6 
- Fixed error on line 139 - "==" was being used, whereas sh expects a "=" (and we do this correctly throughout the rest of the file). See https://www.shellcheck.net/wiki/SC3014 for more.
- Changed the use of backticks to the use of `$()` as specified in https://www.shellcheck.net/wiki/SC2006
- Changed the use of `-a` to `&&` as specified in https://www.shellcheck.net/wiki/SC2166

Closes rustwasm#1159
Closes rustwasm#1217
Closes rustwasm#1283
@lucashorward lucashorward mentioned this issue Aug 7, 2023
Merged
3 tasks
@bitbrain-za bitbrain-za mentioned this issue Jul 23, 2024
Open
@yeskiy yeskiy mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nuke-web3