Remove compiler warnings in todo example #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/todomvc/src/element.rs
Outdated
| let el_et: web_sys::EventTarget = el.into(); | ||
| el_et.add_event_listener_with_callback(event_name, cb.as_ref().unchecked_ref()); | ||
| let el_et: EventTarget = el.into(); | ||
| let _r = el_et.add_event_listener_with_callback(event_name, cb.as_ref().unchecked_ref()); |
There was a problem hiding this comment.
Shouldn't results like these be propagated out as an exception?
jonathanKingston
force-pushed
the
todo-clean
branch
from
5e3427b
to
d958782
Compare
…into element.rs and fix a bug with focus not working on edit.
jonathanKingston
force-pushed
the
todo-clean
branch
from
d958782
to
d59716b
Compare
|
@alexcrichton sorry for the delay here. I used console_error_panic_hook for the errors however I think it would be nicer to be exceptions though (perhaps that should be a feature flag for this crate?). |
|
Ok no worries! We can always continue to iterate in-tree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently ignoring Results from the DOM as for most cases I don't really think there is much recovery, perhaps they should behave like a panic?