Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need change of set_local_description constructor #3394

Open
JSmithOner opened this issue Apr 20, 2023 · 1 comment
Open

need change of set_local_description constructor #3394

JSmithOner opened this issue Apr 20, 2023 · 1 comment
Labels

Comments

@JSmithOner
Copy link

JSmithOner commented Apr 20, 2023

Describe the Bug

set_local_description requires a &RtcSessionDescriptionInit to be executed
I can't see the method restartIce neither

basically a lot the current js method and properties don't exist or are incomplete

Steps to Reproduce

look at the rustwasm doc and look a the MDN doc

Expected Behavior

The method should also be callable without argument.

Actual Behavior

the description doesn't get set automatically.

@JSmithOner JSmithOner added the bug label Apr 20, 2023
@daxpedda
Copy link
Collaborator

set_local_description requires a &RtcSessionDescriptionInit to be executed

I'm not sure what happened there, but the WebIDL was defined incorrectly in wasm-bindgen, the parameter should be optional: https://www.w3.org/TR/webrtc/#ref-for-dom-peerconnection-setlocaldescription-4.

Unfortunately this can only be fixed in the next breaking change release.

I can't see the method restartIce neither

This should be easy to add. Would you like to make a PR?
wasm-bindgen Guide to add new Web APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants