Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator.prototype.next should return IteratorNext #1489

Open
RReverser opened this issue Apr 26, 2019 · 0 comments
Open

Generator.prototype.next should return IteratorNext #1489

RReverser opened this issue Apr 26, 2019 · 0 comments
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) js-sys Issues related to the `js-sys` crate

Comments

@RReverser
Copy link
Member

Generator.prototype.next is currently bound with a return of Result<JsValue, JsValue>, but it should use Result<IteratorNext, JsValue> for consistency with regular iterators instead (as it returns same object of { value, done }).

This would be a breaking change.
@RReverser RReverser added the bug Something isn't working label Apr 26, 2019
@alexcrichton alexcrichton added breaking-change Tracking breaking changes for the next major version bump (if ever) js-sys Issues related to the `js-sys` crate and removed bug Something isn't working labels Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) js-sys Issues related to the `js-sys` crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @RReverser