Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thirty SVG elements’ names have the wrong case #1337

Open
chris-morgan opened this issue Mar 11, 2019 · 1 comment
Open

Thirty SVG elements’ names have the wrong case #1337

chris-morgan opened this issue Mar 11, 2019 · 1 comment
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) web-sys Issues related to the `web-sys` crate

Comments

@chris-morgan
Copy link

The following SVG element types should have their fourth letter capitalised:

  • SvgaElement
  • SvgfeBlendElement
  • SvgfeColorMatrixElement
  • SvgfeComponentTransferElement
  • SvgfeCompositeElement
  • SvgfeConvolveMatrixElement
  • SvgfeDiffuseLightingElement
  • SvgfeDisplacementMapElement
  • SvgfeDistantLightElement
  • SvgfeDropShadowElement
  • SvgfeFloodElement
  • SvgfeFuncAElement
  • SvgfeFuncBElement
  • SvgfeFuncGElement
  • SvgfeFuncRElement
  • SvgfeGaussianBlurElement
  • SvgfeImageElement
  • SvgfeMergeElement
  • SvgfeMergeNodeElement
  • SvgfeMorphologyElement
  • SvgfeOffsetElement
  • SvgfePointLightElement
  • SvgfeSpecularLightingElement
  • SvgfeSpotLightElement
  • SvgfeTileElement
  • SvgfeTurbulenceElement
  • SvggElement
  • SvgmPathElement
  • SvgsvgElement
  • SvgtSpanElement
@chris-morgan chris-morgan added the bug Something isn't working label Mar 11, 2019
@alexcrichton alexcrichton added breaking-change Tracking breaking changes for the next major version bump (if ever) web-sys Issues related to the `web-sys` crate and removed bug Something isn't working labels Mar 11, 2019
@Liamolucko
Copy link
Collaborator

This doesn't have to be a breaking change - the old names could be kept as type aliases and deprecated in favour of the new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) web-sys Issues related to the `web-sys` crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @chris-morgan @Liamolucko