Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mut required for uploading to uniforms #1131

Closed
dakom opened this issue Dec 25, 2018 · 2 comments
Closed

mut required for uploading to uniforms #1131

dakom opened this issue Dec 25, 2018 · 2 comments

Comments

@dakom
Copy link
Contributor

dakom commented Dec 25, 2018 •
edited
Loading

Functions like uniform4fv_with_f32_array() expect a mutable reference to a slice as input

This is really odd imho because you would never expect that function to change the data you pass in.

Also makes it a bit tougher to work with due to borrowing rules...

From looking at the WebIDL it seems this is a Float32List - but I see no indication of why that would be mutable.

Help understanding is greatly appreciated!
@jsheard
Copy link
Contributor

jsheard commented Dec 25, 2018

See #1005

@dakom

This comment was marked as abuse.

Sign in to view
@dakom dakom closed this as completed Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsheard @dakom