Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-pack tutorial paths #154 #15

Closed
jrichocean opened this issue Jun 16, 2018 · 1 comment
Closed

Update wasm-pack tutorial paths #154 #15

jrichocean opened this issue Jun 16, 2018 · 1 comment

Comments

@jrichocean
Copy link

Link to old issue

This issue was opened by @mgattozzi

We're just waiting for a 0.2 release of wasm-pack right now for this issue. In https://github.com/rust-lang-nursery/rust-wasm/pull/151 we changed a path reference from ./node_modules/@MYSCOPE/wasm-add/wasm_add.js to @MYSCOPE/wasm-add/wasm_add.js. As was noted in #151 after ashleygwilliams/wasm-pack#94 is closed we can shorten this further to @MYSCOPE/wasm-add which is more idiomatic for JS.

Mentoring instructions:

  1. In src/wasm-pack/run-the-code.md change the import statement of index.js to the above statement.
  2. Test that the changes work as part of the tutorial with the new syntax
@fitzgen
Copy link
Member

fitzgen commented Aug 2, 2018

The wasm-pack tutorial moved into the wasm-pack repo, please refile this issue there if it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants