Add an example to print trust anchors. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Sep 27, 2021
examples/print-trust-anchors.rs
Outdated
| @@ -0,0 +1,29 @@ | |||
| // Print the Subject of all extracted trust anchors. | |||
There was a problem hiding this comment.
Should probably be an inner attribute (that is, start with //!).
examples/print-trust-anchors.rs
Outdated
| use std::io::{BufRead, Error}; | ||
| use x509_parser::prelude::*; | ||
|
|
||
| struct Printer {} |
There was a problem hiding this comment.
For this, makes sense to replace {} with just ;.
examples/print-trust-anchors.rs
Outdated
| println!("{}", cert.tbs_certificate.subject); | ||
| Ok(()) | ||
| } | ||
| fn load_pem_file(&mut self, rd: &mut dyn BufRead) -> Result<(), Error> { |
There was a problem hiding this comment.
Ideally add an empty line between these two methods.
|
@jsha are you interested in rebasing this for the next release? |
jsha
force-pushed
the
printer
branch
2 times, most recently
from
0aa1c18
to
3b23214
Compare
|
Done! |
djc
reviewed
Oct 12, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a
;that was breaking compile for me.