Deduplicate issuer usage #331
Conversation
| } | ||
| } | ||
|
|
||
| trait ToDer { |
There was a problem hiding this comment.
as I've said previously, I'd prefer a better name for that trait: SignDer or something like it.
There was a problem hiding this comment.
Yup. Do you think the introduction of the trait carries its weight here? I'm not totally convinced...
There was a problem hiding this comment.
not really tbh. I think having consistent inherent functions is better (traits need to be imported to be used/called, and even if you add inherent functions on top, they still add complexity, which needs to be justified, and in this case i think it's not).
Did you want me to hold off reviewing this for now? |
Yup! |
Based on: