Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak doctests #244

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Unbreak doctests #244

merged 3 commits into from
Mar 15, 2024

Conversation

djc
Copy link
Member

@djc djc commented Mar 14, 2024

#233 regressed a doctest for CRL signing. It turns out CI was using test --all-targets which is documented as omitting doctests:

djc-2021 ci-doctests rcgen $ cargo test -h
Execute all unit and integration tests and build examples of a local package

[..]

Target Selection:
      [..]
      --all-targets       Test all targets (does not include doctests)

Instead, just use cargo test which includes all targets by default.

@djc djc requested review from cpu and est31 March 14, 2024 08:58
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you

@est31
Copy link
Member

est31 commented Mar 15, 2024

at least according to my 4 year old and probably outdated table there is no single cargo command that tests everything, cargo test misses benches for example. But that's fine as we don't have benches (but we do have doctests so this is an improvement).

@djc djc added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 1bd41a1 Mar 15, 2024
42 checks passed
@djc djc deleted the ci-doctests branch March 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants