Bumped num dependency version #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is |
Collaborator
|
It is. |
Contributor
Author
|
I am not quite sure is it minor/major fix to make a correct version bump. |
Collaborator
|
@not-fl3 should be 0.19.0 then. Before 1.0 the patch versions are non-breaking and minor versions are breaking. |
Rhuagh
reviewed
Nov 22, 2018
Collaborator
Rhuagh
left a comment
Rhuagh
left a comment
There was a problem hiding this comment.
Can you update the version number in the pr? I can publish tonight, but don't have time to do the versioning myself
Contributor
Author
|
Done :) |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2018
105: Bumped num dependency version r=Rhuagh a=not-fl3 The problem: ```num``` 0.1 had ```rustc_serialize``` dependency, which cant be compiled on wasm32-unknown-unknown. ```num``` 0.1 did not set ```default_features = false``` for its serde-related sub-dependencies, so enabling ```num/serde``` feature resulted ```rustc_serialize``` in the ```collision-rs``` dependencies. Switch to 0.2 was an easy fix. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rustgd/collision-rs/105) <!-- Reviewable:end --> Co-authored-by: not-fl3 <not.fl3@gmail.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
num0.1 hadrustc_serializedependency, which cant be compiled on wasm32-unknown-unknown.num0.1 did not setdefault_features = falsefor its serde-related sub-dependencies, so enablingnum/serdefeature resultedrustc_serializein thecollision-rsdependencies. Switch to 0.2 was an easy fix.This change is