This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Adds a way to specify the seed for RNG #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philpax
approved these changes
Mar 18, 2023
llama-cli/src/main.rs
Outdated
| @@ -2,7 +2,7 @@ use std::{convert::Infallible, io::Write}; | |||
|
|
|||
| use cli_args::CLI_ARGS; | |||
| use llama_rs::{InferenceParameters, InferenceSnapshot}; | |||
| use rand::thread_rng; | |||
| use rand::{thread_rng, SeedableRng}; | |||
There was a problem hiding this comment.
thread_rng is no longer used
There was a problem hiding this comment.
Looks like CI's borked, it didn't catch this: https://github.com/setzer22/llama-rs/actions/runs/4455272439/jobs/7824987492?pr=36
Clippy emitted the warning, but the test didn't faill
There was a problem hiding this comment.
Looks like we need to add -Dwarnings to the clippy command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #27 (at least the part we can implement, deterministic floating point math is out of scope for the project).
This allows specifying a
--seedvalue inllama-cli. If no value is passed, the rng is seeded from system entropy like before.