Skip to content

implement strip #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2024
Merged

implement strip #83

merged 4 commits into from
May 1, 2024

Conversation

grisenti
Copy link
Contributor

No description provided.

@jgarzik
Copy link
Contributor

jgarzik commented Apr 30, 2024

Review: Overall looks good and mostly ready to merge. some minor changes only:

  • make main look similar to other posixutils, notably initializating the gettext system.
  • remove final ".0" from object crate version. We prefer to auto-upgrade minor versions automatically. e.g. 0.35 not 0.35.0.
  • include top-of-file copyright, which should be assigned to Hemi Labs, Inc.

And a more general review question: The object crate claims to support many formats. Is it possible to support files such as COFF without much additional code?

@grisenti
Copy link
Contributor Author

grisenti commented May 1, 2024

And a more general review question: The object crate claims to support many formats. Is it possible to support files such as COFF without much additional code?

The code is based on the build API of the object crate, which is currently only available for the elf format (https://docs.rs/object/latest/object/build/index.html). There is a unified write API (https://docs.rs/object/latest/object/write/index.html), but it doesn't support writing executables. There are also format specific APIs (for example https://docs.rs/object/latest/object/write/elf/struct.Writer.html), but they are very low level and in my opinion would require a lot more code

@jgarzik jgarzik merged commit 75c29cf into rustcoreutils:main May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants