split: impl struct Suffix and add tests#313
Merged
jgarzik merged 2 commits intorustcoreutils:mainfrom Oct 13, 2024
fox0:split
Merged
split: impl struct Suffix and add tests#313jgarzik merged 2 commits intorustcoreutils:mainfrom fox0:split
jgarzik merged 2 commits intorustcoreutils:mainfrom
fox0:split
Conversation
jgarzik
requested changes
Oct 12, 2024
Contributor
jgarzik
left a comment
jgarzik
left a comment
There was a problem hiding this comment.
OK except for small detail - panic message text
| match &mut self.outf { | ||
| Some(ref mut f) => f.write_all(buf), | ||
| None => Ok(()), | ||
| None => panic!("lol"), |
Contributor
There was a problem hiding this comment.
heh, but need to do better.
Put a real error message there.
jgarzik
reviewed
Oct 13, 2024
| Some(ref mut f) => f.write_all(buf), | ||
| None => panic!("lol"), | ||
| // TODO: | ||
| None => panic!("unreachable"), |
Contributor
There was a problem hiding this comment.
fwiw, you can use macro unreachable!()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also returned assert!(false); in
fn write()