Skip to content

[timeout] full implementation, 3d iteration #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 26, 2024

Conversation

Wandalen
Copy link
Contributor

No description provided.

@Wandalen Wandalen marked this pull request as draft September 20, 2024 16:57
@Wandalen
Copy link
Contributor Author

Might fail because of grep

@Wandalen Wandalen marked this pull request as ready for review September 20, 2024 19:29
@jgarzik jgarzik added the enhancement New feature or request label Sep 21, 2024
@Wandalen Wandalen marked this pull request as draft September 25, 2024 15:38
@Wandalen Wandalen marked this pull request as ready for review September 25, 2024 16:02
@Wandalen
Copy link
Contributor Author

Ready @jgarzik

@jgarzik
Copy link
Contributor

jgarzik commented Sep 25, 2024

Although CI is succeeding, local tests with Ubuntu Linux 22.04 LTS are failing:

failures:

---- timeout::test_utility_error stdout ----
thread 'timeout::test_utility_error' panicked at process/tests/timeout/mod.rs:66:5:
assertion `left == right` failed
  left: "/usr/bin/sleep: invalid time interval 'invalid_value'\nTry '/usr/bin/sleep --help' for more information.\n"
 right: "/usr/bin/sleep: invalid time interval ‘invalid_value’\nTry '/usr/bin/sleep --help' for more information.\n"
stack backtrace:
   0: rust_begin_unwind
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
   2: core::panicking::assert_failed_inner
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:410:17
   3: core::panicking::assert_failed
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:365:5
   4: process_tests::timeout::run_test
             at ./tests/timeout/mod.rs:66:5
   5: process_tests::timeout::timeout_test
             at ./tests/timeout/mod.rs:85:5
   6: process_tests::timeout::test_utility_error
             at ./tests/timeout/mod.rs:244:5
   7: process_tests::timeout::test_utility_error::{{closure}}
             at ./tests/timeout/mod.rs:237:24
   8: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
   9: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    timeout::test_utility_error

test result: FAILED. 38 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 10.29s

@Wandalen Wandalen marked this pull request as draft September 25, 2024 19:01
@Wandalen Wandalen marked this pull request as ready for review September 26, 2024 06:31
@Wandalen
Copy link
Contributor Author

@jgarzik fixed

@jgarzik jgarzik merged commit fce87eb into rustcoreutils:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants