[make] full implementation according specification #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wandalen
force-pushed
the
make
branch
3 times, most recently
from
348f359 to
a7e977e
Compare
Wandalen
force-pushed
the
make
branch
3 times, most recently
from
6d45c76 to
a347ee7
Compare
Wandalen
force-pushed
the
make
branch
3 times, most recently
from
2cd17dd to
6c7862c
Compare
Wandalen
changed the title
|
@jgarzik ready for review |
jgarzik
requested changes
Oct 23, 2024
m4/tests/integration_test.rs
Outdated
| @@ -109,7 +109,7 @@ fn run_command(input: &Path) -> std::process::Output { | |||
| #[test] | |||
| fn test_bsd() { | |||
| init(); | |||
| let output = run_command(Path::new("fixtures/integration_tests/bsd.m4")); | |||
| let output = run_command(&Path::new("fixtures/integration_tests/bsd.m4")); | |||
There was a problem hiding this comment.
merge error. This PR should not touch m4/
plib/src/testing.rs
Outdated
| @@ -84,9 +84,6 @@ pub fn run_test(plan: TestPlan) { | |||
| let stdout = String::from_utf8_lossy(&output.stdout); | |||
| assert_eq!(stdout, plan.expected_out); | |||
|
|
|||
| let stderr = String::from_utf8_lossy(&output.stderr); | |||
| assert_eq!(stderr, plan.expected_err); | |||
|
|
|||
There was a problem hiding this comment.
Change rejected -- This change deletes some tests across all utilities.
|
@jgarzik took into account. is there anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.