fix(kms): run modesetting after the surface is resized#272
Open
esposm03 wants to merge 3 commits intorust-windowing:masterfrom
Open
fix(kms): run modesetting after the surface is resized#272esposm03 wants to merge 3 commits intorust-windowing:masterfrom
esposm03 wants to merge 3 commits intorust-windowing:masterfrom
Conversation
Without setting the UniversalPlanes capability, only planes with PlaneType::Overlay are returned by the kernel. This commit allows the example to run on devices that don't have any of those, but have at least one Primary plane
notgull
requested changes
Aug 13, 2025
| let mode = self | ||
| .connectors | ||
| .iter() | ||
| .flat_map(|con| self.display.get_modes(*con).unwrap()) |
Member
There was a problem hiding this comment.
Any chance we can bubble this error up instead of unwrapping on it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user called
Surface::resizewith thekmsbackend, no modesetting was done. At least on the devices I tested with, this made the page flips fail, returningEBUSY. This is now fixed by callingset_crtcinside theresizefunction.Additionally, I made the drm example request the UniversalPlanes ClientCapability, since that allows the example to run on less powerful devices that don't have any overlay planes (Unless the client sets that capability, the kernel only returns overlay frames from the
Device::plane_handles()call).Fixes #271.