Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PartialEq for errors in vm-memory #194

Open
andreeaflorescu opened this issue Apr 5, 2022 · 0 comments · May be fixed by #206
Open

Implement PartialEq for errors in vm-memory #194

andreeaflorescu opened this issue Apr 5, 2022 · 0 comments · May be fixed by #206

Comments

@andreeaflorescu
Copy link
Member

The lack of PartialEq in vm-memory is forcing weird patterns across all rust-vmm crates (where errors need to be compared using match or even worse where errors are not compared at all). The problem with implementing PartialEq resides in the underlying io::Error which does not implement PartialEq. Since the use case for errors is pretty well defined in vm-memory, we should be able to manually implement PartialEq because we can reason about what errors should actually be equal.

@AlexandruCihodaru AlexandruCihodaru linked a pull request Oct 10, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant