You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lack of PartialEq in vm-memory is forcing weird patterns across all rust-vmm crates (where errors need to be compared using match or even worse where errors are not compared at all). The problem with implementing PartialEq resides in the underlying io::Error which does not implement PartialEq. Since the use case for errors is pretty well defined in vm-memory, we should be able to manually implement PartialEq because we can reason about what errors should actually be equal.
The text was updated successfully, but these errors were encountered:
The lack of PartialEq in vm-memory is forcing weird patterns across all rust-vmm crates (where errors need to be compared using
match
or even worse where errors are not compared at all). The problem with implementingPartialEq
resides in the underlying io::Error which does not implementPartialEq
. Since the use case for errors is pretty well defined in vm-memory, we should be able to manually implementPartialEq
because we can reason about what errors should actually be equal.The text was updated successfully, but these errors were encountered: