-
Notifications
You must be signed in to change notification settings - Fork 33
Comparing changes
Open a pull request
base repository: rust-vmm/rust-vmm-ci
base: 665f31f4b4e050270604d9b534058fa9b9d39adc
head repository: rust-vmm/rust-vmm-ci
compare: b31e811bb4bca25b5d1d203ef97eddd073194fd0
- 13 commits
- 6 files changed
- 5 contributors
Commits on Sep 27, 2023
-
README: Fix link to setup_new_repo.md
The community repo has moved documents from the `maintainers` folder: rust-vmm/community@9c611c5 Signed-off-by: Tan En De <ende.tan@starfivetech.com>
Configuration menu - View commit details
-
Copy full SHA for 9751aaa - Browse repository at this point
Copy the full SHA 9751aaaView commit details
Commits on Oct 20, 2023
-
Generate Cargo.lock before call
cargo audit
Starting from v0.18.0, cargo-audit hangs indefinitely if Cargo.lock does not exist. We discovered this while upgrading the container from v26 to v28 [1], which among other things updated cargo-audit. For the binary crates this should not be a problem, since they have Cargo.lock committed, but for many libraries this may not be true. If Cargo.lock is not there, we are generating one with the latest available versions, which may not be very significant. For this and other reasons it's now suggested that libraries also have a Cargo.lock [2] committed (thanks Manos for pointing this out). Note: `cargo generate-lockfile` updates Cargo.lock if it's already there, but we don't want it, that's why we have the guard. [1] #138 [2] https://doc.rust-lang.org/nightly/cargo/faq.html#why-have-cargolock-in-version-control Suggested-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Suggested-by: Patrick Roy <roypat@amazon.co.uk> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 352bc23 - Browse repository at this point
Copy the full SHA 352bc23View commit details -
test_coverage.py: fix formatting
CI is failing since `black` suggests some reformatting. Let's apply them. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for b6483eb - Browse repository at this point
Copy the full SHA b6483ebView commit details -
test_coverage: put exclude_path value between double quotes
We don't want the shell to interpret the contents of exclude_path, but we want it all used as a single string for `--ignore-filename-regex`, so let's put it between double quotes. An example of failure is when we have | , as in this case: $ CARGO_TARGET_DIR=./cov_build cargo llvm-cov test --summary-only \ --ignore-filename-regex crates/virtio-bindings|crates/virtio-queue/src/mock.rs \ --workspace --features=virtio-blk/backend-stdio bash: crates/virtio-queue/src/mock.rs: Permission denied ... error: failed to generate report: process didn't exit successfully: ... (exit status: 74) Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 9699b4d - Browse repository at this point
Copy the full SHA 9699b4dView commit details -
Update
exclude_path
description and examplesNow that we use cargo-llvm-cov, `exclude_path` should be a regular expression, since we are using `--ignore-filename-regex` option: --ignore-filename-regex <PATTERN> Skip source code files with file paths that match the given regular expression To prevent users from separating multiple files with commas, let's update the `exclude_path` description in the README and in the examples. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 4c55aa7 - Browse repository at this point
Copy the full SHA 4c55aa7View commit details
Commits on Oct 23, 2023
-
Update container version to v28
This new version contains alsa and pipewire libraries to build vhost-device-sound audio backends. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 0b9e2e2 - Browse repository at this point
Copy the full SHA 0b9e2e2View commit details
Commits on Oct 24, 2023
-
test_coverage: fix formatting of --ignore-filename-regex
`black` suggests putting the string between single quotes so there is no need to escape double quotes. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for be28ad8 - Browse repository at this point
Copy the full SHA be28ad8View commit details
Commits on Nov 3, 2023
-
test_coverage: calculate the difference in reverse
If we increase the coverage the message prints a negative value as the difference from the previous value. This can be confusing as it looks like the coverage has decreased. For example if the value in coverage_config_x86_64.json is 73.42, and the new coverage is 73.96 (increased), we have the following error: ValueError: Current code coverage (73.96%) deviates by -0.54% from the previous code co... Let's calculate the difference in reverse so that we have a negative value if it decreases and positive otherwise. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for cf98097 - Browse repository at this point
Copy the full SHA cf98097View commit details
Commits on Nov 14, 2023
-
README: add link to rust-vmm-container repository
For convenience, since the two are related directly. Also fix a small typo while at it. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Configuration menu - View commit details
-
Copy full SHA for f91cfeb - Browse repository at this point
Copy the full SHA f91cfebView commit details -
Update container version to v29
The new version reduces the size of the container by removing unneeded pipewire dependencies and adds dbus. This is needed to test vhost-device-sound. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 1f5d329 - Browse repository at this point
Copy the full SHA 1f5d329View commit details
Commits on Nov 15, 2023
-
update container version to v30
This version adds the necessary Rust targets to run tests for no-std crates. Signed-off-by: Andreea Florescu <fandree@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 0100de0 - Browse repository at this point
Copy the full SHA 0100de0View commit details
Commits on Jan 3, 2024
-
update container version to v31
This version adds musl-tools package which is required for rust-vmm/vhost#218 to compile userfaultfd crate for musl target. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Configuration menu - View commit details
-
Copy full SHA for cd1e502 - Browse repository at this point
Copy the full SHA cd1e502View commit details
Commits on Jan 4, 2024
-
update container version to v32
This version adds minor changes needed for musl-tools package to properly find linux headers. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Configuration menu - View commit details
-
Copy full SHA for b31e811 - Browse repository at this point
Copy the full SHA b31e811View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 665f31f4b4e050270604d9b534058fa9b9d39adc...b31e811bb4bca25b5d1d203ef97eddd073194fd0