Merge pull request #140 from adamreichold/boy-scouting

Author: cfvescovo

.github/workflows/test.yml

@@ -30,7 +30,7 @@ jobs:
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features
+          args: --all-targets --all-features
   test:
     runs-on: ubuntu-latest
     strategy:

Cargo.lock

@@ -14,7 +14,7 @@ fn main() {
     stdin.read_line(&mut input).unwrap();
     let selector = Selector::parse(&input).unwrap();
 
-    write!(stdout, "HTML document:\n").unwrap();
+    writeln!(stdout, "HTML document:").unwrap();
     stdout.flush().unwrap();
     input.clear();
     stdin.read_to_string(&mut input).unwrap();

examples/document.rs

@@ -14,7 +14,7 @@ fn main() {
     stdin.read_line(&mut input).unwrap();
     let selector = Selector::parse(&input).unwrap();
 
-    write!(stdout, "HTML fragment:\n").unwrap();
+    writeln!(stdout, "HTML fragment:").unwrap();
     stdout.flush().unwrap();
     input.clear();
     stdin.read_to_string(&mut input).unwrap();

examples/fragment.rs

@@ -150,24 +150,18 @@ mod tests {
         let sel = Selector::parse("p").unwrap();
 
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(
-            true,
-            element.has_id(
-                &CssLocalName::from("link_id_456"),
-                CaseSensitivity::CaseSensitive
-            )
-        );
+        assert!(element.has_id(
+            &CssLocalName::from("link_id_456"),
+            CaseSensitivity::CaseSensitive
+        ));
 
         let html = "<p>hey there</p>";
         let fragment = Html::parse_fragment(html);
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(
-            false,
-            element.has_id(
-                &CssLocalName::from("any_link_id"),
-                CaseSensitivity::CaseSensitive
-            )
-        );
+        assert!(!element.has_id(
+            &CssLocalName::from("any_link_id"),
+            CaseSensitivity::CaseSensitive
+        ));
     }
 
     #[test]
@@ -176,13 +170,13 @@ mod tests {
         let fragment = Html::parse_fragment(html);
         let sel = Selector::parse("link").unwrap();
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(true, element.is_link());
+        assert!(element.is_link());
 
         let html = "<p>hey there</p>";
         let fragment = Html::parse_fragment(html);
         let sel = Selector::parse("p").unwrap();
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(false, element.is_link());
+        assert!(!element.is_link());
     }
 
     #[test]
@@ -191,24 +185,18 @@ mod tests {
         let fragment = Html::parse_fragment(html);
         let sel = Selector::parse("p").unwrap();
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(
-            true,
-            element.has_class(
-                &CssLocalName::from("my_class"),
-                CaseSensitivity::CaseSensitive
-            )
-        );
+        assert!(element.has_class(
+            &CssLocalName::from("my_class"),
+            CaseSensitivity::CaseSensitive
+        ));
 
         let html = "<p>hey there</p>";
         let fragment = Html::parse_fragment(html);
         let sel = Selector::parse("p").unwrap();
         let element = fragment.select(&sel).next().unwrap();
-        assert_eq!(
-            false,
-            element.has_class(
-                &CssLocalName::from("my_class"),
-                CaseSensitivity::CaseSensitive
-            )
-        );
+        assert!(!element.has_class(
+            &CssLocalName::from("my_class"),
+            CaseSensitivity::CaseSensitive
+        ));
     }
 }

src/element_ref/element.rs

@@ -70,6 +70,11 @@ impl<'a> ElementRef<'a> {
         self.serialize(TraversalScope::ChildrenOnly(None))
     }
 
+    /// Returns the value of an attribute.
+    pub fn attr(&self, attr: &str) -> Option<&str> {
+        self.value().attr(attr)
+    }
+
     /// Returns an iterator over descendent text nodes.
     pub fn text(&self) -> Text<'a> {
         Text {