Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #2

Open
TDHolmes opened this issue Aug 9, 2020 · 6 comments
Open

Add unit tests #2

TDHolmes opened this issue Aug 9, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TDHolmes
Copy link

TDHolmes commented Aug 9, 2020

We've added CI to ensure it builds & we don't get clippy regressions, but this doesn't prevent runtime issues

@TDHolmes TDHolmes added the enhancement New feature or request label Aug 30, 2020
@TDHolmes
Copy link
Author

It's unclear to me how to run tests on an actual pi. Does GitHub support docker easily?

@TDHolmes TDHolmes added the help wanted Extra attention is needed label Aug 30, 2020
@TDHolmes
Copy link
Author

TDHolmes commented Sep 7, 2020

Looks like we would need to setup our own GitHub Actions runner to enable this, or have the C API mocked out like #12 was trying to do. In the meantime, the existing unit tests do work, as long as you specify --test-threads 1 in your invocation of cargo test.

@BroderickCarlin
Copy link

@TDHolmes Github does support Docker easily as a part of workflows if you believe that is beneficial

@TDHolmes
Copy link
Author

TDHolmes commented Sep 8, 2020

surprisingly, the C++ library compiles in normal ubuntu, so I think we could do jelly bean GitHub actions compilation. However, the actual runtime behavior might be weird :p Lets wait and see for #1 since before then, linking properly will be... tricky.

@TDHolmes
Copy link
Author

TDHolmes commented Jan 3, 2022

I tried to get this going with #27 without success

@TDHolmes
Copy link
Author

TDHolmes commented Jan 3, 2022

Tests using the stub functions would work though, however most of the library relies on the FFI so not sure if that's beneficial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants