Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Comment? #1445

Closed
idontgetoutmuch opened this issue May 3, 2024 · 1 comment
Closed

Incorrect Comment? #1445

idontgetoutmuch opened this issue May 3, 2024 · 1 comment
Assignees
Labels
E-easy Participation: easy job

Comments

@idontgetoutmuch
Copy link

// p1 + area of left tail

presumably

// p1 + area of left tail

should be

// p2 + area of left tail
@dhardy
Copy link
Member

dhardy commented Jun 12, 2024

You are probably right; similarly for the next comment down.

In general, such comments are not especially useful; in this case it makes more sense to refer to the paper to understand the algorithm: https://dl.acm.org/doi/pdf/10.1145/42372.42381

Suggestion: remove these comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Participation: easy job
Projects
None yet
Development

No branches or pull requests

4 participants