Fix the examples in the docs #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. If you fix the clippy lints, I will merge. |
|
Will do, but on Monday. |
Julian-Wollersberger
force-pushed
the
doc-tests
branch
from
918884e to
4a949d3
Compare
|
Clippy, cargo doc and cargo fmt should be happy now. |
|
Something seems to have changed in beta over the weekend as this PR's checks are failing for the same reason the overnights suddenly failed today as well. If you tested clippy locally the PR should be fine. I'll merge once I figure out what's going on. |
|
Yes, I tested with stable clippy locally. |
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And mark them as
no_runinstead ofignore, so they don't regress again.Apparently the return type of
Device::lookup()had changed and the docs weren't updated.