Fix emit inconsitencies and add tests #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to convert the parsed payload of information elements into the binary format, I've noticed inconsistencies regarding some emit implementations.
I've fixed some of them (which I needed) mostly based on the assumption, that the
Parsable
implementation is correct.On exception is the
Nl80211RateAndSelector
implementation, where the comments from this type andNl80211Element::SupportedRatesAndSelectors
where already inconsistent.Also I've added some roudtrip test, using macros to reduce the repetition. I thought about adding more tests, but I wanted to propose this as a starting point for now.