-
Notifications
You must be signed in to change notification settings - Fork 67
Route get supports querying the route tables #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Orycterope
wants to merge
1
commit into
rust-netlink:main
Choose a base branch
from
Orycterope:route_get_query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// SPDX-License-Identifier: MIT | ||
|
||
use std::net::IpAddr; | ||
|
||
use futures::{Stream, TryStreamExt}; | ||
use netlink_packet_route::RouteMessage; | ||
use rtnetlink::{new_connection, Error, Handle}; | ||
|
||
#[tokio::main] | ||
async fn main() { | ||
let (connection, handle, _) = new_connection().unwrap(); | ||
tokio::spawn(connection); | ||
|
||
let destinations = [ | ||
"8.8.8.8".parse().unwrap(), | ||
"127.0.0.8".parse().unwrap(), | ||
"2001:4860:4860::8888".parse().unwrap(), | ||
"::1".parse().unwrap(), | ||
]; | ||
for dest in destinations { | ||
println!("getting best route to {}", dest); | ||
if let Err(e) = dump_route_to(handle.clone(), dest).await { | ||
eprintln!("{e}"); | ||
} | ||
println!(); | ||
} | ||
} | ||
|
||
async fn dump_route_to(handle: Handle, dest: IpAddr) -> Result<(), Error> { | ||
let mut routes: Box< | ||
dyn Stream<Item = Result<RouteMessage, rtnetlink::Error>> + Unpin, | ||
> = match dest { | ||
IpAddr::V4(v4) => Box::new(handle.route().get().v4().to(v4).execute()), | ||
IpAddr::V6(v6) => Box::new(handle.route().get().v6().to(v6).execute()), | ||
}; | ||
if let Some(route) = routes.try_next().await? { | ||
println!("{route:?}"); | ||
} | ||
Ok(()) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the generic struct is not required here, you can just use the generic function parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generic parameter on the struct prevent the user from calling
to(ipv6_ipaddr)
on an ipv4 RouteGetRequest because it would result in an unsupported rtnetlink request. Once theRouteGetRequest<()>
is specialized into aRouteGetRequest<Ipv4Addr>
, you can only pass it ipv4 addresses when callingto
andfrom
. This is enforced by the type system, and there is no way for the user to turn it into aRouteGetRequest<Ipv6Addr>
.Moving the generics on the function instead would not prevent the user to create a
RouteGetRequest
, callto::<Ipv4Addr>(dest_ip)
and thenfrom::<Ipv6Addr>(source_ip)
, which is invalid.