Support full done message #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, done messages are treated as having a zero-sized payload but they are expected to have at least a 4 byte payload holding an error code. This causes issues when serializing done messages that are consumed applications expecting conformant done messages. See https://kernel.org/doc/html/next/userspace-api/netlink/intro.html#netlink-message-types for details. Fixes #11
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
===========================================
+ Coverage 49.85% 66.88% +17.03%
===========================================
Files 6 7 +1
Lines 337 453 +116
===========================================
+ Hits 168 303 +135
+ Misses 169 150 -19
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wllenyj
approved these changes
Jun 14, 2023
|
Thanks for the approval :)! How do I get this submitted? |
|
kind ping here for submission :) |
|
Update: No the core does not need generic. Let me do the release now. |
|
0.6.0 released with this done message support. https://github.com/rust-netlink/netlink-packet-core/releases/tag/v0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, done messages are treated as having a zero-sized payload but they are expected to have at least a 4 byte payload holding an error code. This causes issues when serializing done messages that are consumed applications expecting conformant done messages.
See https://kernel.org/doc/html/next/userspace-api/netlink/intro.html#netlink-message-types for details.
Fixes #11