Conversation
ae1b162 to
61c18c9
Compare
61c18c9 to
db87d41
Compare
|
Hey @barakugav, thanks for the PR. I have two things I'm worried about here: first, |
|
the implementation is more complicate than the simpler sum-then-divide not due to performance, but due to float overflow., subtracting the max value is standard in softmax implementation and the regular implementation is not practical. Anyway, thanks for the feedback, ill look for a more appropriate crate for this implementation |
No description provided.