Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to specify the used driver #206

Open
xFrednet opened this issue Jul 28, 2023 · 0 comments
Open

Allow the user to specify the used driver #206

xFrednet opened this issue Jul 28, 2023 · 0 comments
Labels
A-marker-cargo Area: All things connected to `cargo_marker` C-enhancement Category: New feature or request

Comments

@xFrednet
Copy link
Member

The driver for marker, is usually installed using the cargo marker setup command. This command installs the driver version hardcoded in cargo-marker. It would be good if the user could manually specify the driver version and toolchain.

Note, that the version and toolchain always have to be provided as a pair. It would be cool if marker would have a mapping of toolchain -> driver version. But the only way I can think of would require manually having a list. Having the user specify both for now, should be fine.

I believe the best solution for this, would be to add a new field to marker's configuration under the workspace.metadata.marker section in Cargo.toml

[workspace.metadata.marker]
driver = { version = "0.1.0", toolchain = "2023-07-13"}

Optional: For testing purposes, it would also be cool if a path could be used instead of the version field. (Maybe guarded by the dev-build feature)

@xFrednet xFrednet added C-enhancement Category: New feature or request A-marker-cargo Area: All things connected to `cargo_marker` labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-marker-cargo Area: All things connected to `cargo_marker` C-enhancement Category: New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant