Skip to content

Implement the prioritize command #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2020
Merged

Implement the prioritize command #456

merged 2 commits into from
Apr 10, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Closes #453 (hopefully :D)
cc @Mark-Simulacrum @spastorino

@LeSeulArtichaut LeSeulArtichaut marked this pull request as draft April 10, 2020 11:56
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Left a few comments.

spastorino
spastorino reviewed Apr 10, 2020
View reviewed changes
src/handlers/prioritize.rs Outdated
let zulip_req = client.post("https://rust-lang.zulipchat.com/api/v1/messages")
.form(&[
("type", "stream"),
("to", config.zulip_stream.to_string().as_str()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the stream configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's configurable in triagebot.toml

@Mark-Simulacrum
Copy link
Member

Please de-draft and ping me explicitly once this is ready for another review pass (and hopefully, merging :)

@LeSeulArtichaut LeSeulArtichaut marked this pull request as ready for review April 10, 2020 13:00
@LeSeulArtichaut @spastorino @Mark-Simulacrum
Adress review comments
3a182c1 
Co-authored-by: spastorino <spastorino@gmail.com>
Co-authored-by: Mark-Simulacrum <mark.simulacrum@gmail.com>
@LeSeulArtichaut
Copy link
Contributor Author

@Mark-Simulacrum I think it is good for review, I adressed all the previous review comments.
Also, do you want me to write unit tests for this feature?

@LeSeulArtichaut
Copy link
Contributor Author

Oh, I don't think it takes into account whether we are in a PR on in a regular issue. @spastorino should we allow @rustbot prioritize in PRs?

@Mark-Simulacrum
Copy link
Member

I think it's fine to allow it everywhere, no need for special error handling.

@Mark-Simulacrum
Copy link
Member

Once CI passes I'm going to go ahead and merge (it should auto-deploy). Please file a PR against rust-lang/rust enabling it there as well so we can get that landed.

It would also be good to add a page to the wiki, https://github.com/rust-lang/triagebot/wiki, see other pages there for sample content.

@LeSeulArtichaut
Copy link
Contributor Author

I'll open the PR

@Mark-Simulacrum Mark-Simulacrum merged commit 309e0aa into rust-lang:master Apr 10, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the prioritize branch April 10, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorino spastorino spastorino left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rustbot prioritize command
3 participants
@LeSeulArtichaut @Mark-Simulacrum @spastorino