Disable colored help and error output in commands

Author: Kobzol

src/zulip.rs

@@ -1,6 +1,6 @@
 pub mod api;
 pub mod client;
-mod commands;
+pub mod commands;
 
 use crate::db::notifications::add_metadata;
 use crate::db::notifications::{self, delete_ping, move_indices, record_ping, Identifier};
@@ -14,9 +14,10 @@ use crate::team_data::{people, teams};
 use crate::utils::pluralize;
 use crate::zulip::api::{MessageApiResponse, Recipient};
 use crate::zulip::client::ZulipClient;
-use crate::zulip::commands::{ChatCommand, LookupCmd, StreamCommand, WorkqueueCmd, WorkqueueLimit};
+use crate::zulip::commands::{
+    parse_no_color, ChatCommand, LookupCmd, StreamCommand, WorkqueueCmd, WorkqueueLimit,
+};
 use anyhow::{format_err, Context as _};
-use clap::Parser;
 use rust_team_data::v1::TeamKind;
 use std::fmt::Write as _;
 use subtle::ConstantTimeEq;
@@ -192,7 +193,7 @@ fn handle_command<'a>(
 
         // Missing stream means that this is a direct message
         if message_data.stream_id.is_none() {
-            let cmd = ChatCommand::try_parse_from(words)?;
+            let cmd = parse_no_color::<ChatCommand, _>(words.into_iter())?;
             match cmd {
                 ChatCommand::Acknowledge { identifier } => {
                     acknowledge(&ctx, gh_id, (&identifier).into()).await
@@ -218,7 +219,7 @@ fn handle_command<'a>(
             if cmd_index >= words.len() {
                 return Ok(Some("Unknown command".to_string()));
             }
-            let cmd = StreamCommand::try_parse_from(&words[cmd_index..])?;
+            let cmd = parse_no_color::<StreamCommand, _>(words[cmd_index..].into_iter().copied())?;
             match cmd {
                 StreamCommand::EndTopic => {
                     post_waiter(&ctx, message_data, WaitingMessage::end_topic())

src/zulip/commands.rs

@@ -1,11 +1,12 @@
 use crate::db::notifications::Identifier;
 use crate::db::review_prefs::RotationMode;
+use clap::{ColorChoice, Parser};
 use std::num::NonZeroU32;
 use std::str::FromStr;
 
 /// Command sent in a DM with triagebot on Zulip.
 #[derive(clap::Parser, Debug)]
-#[clap(override_usage("<command>"))]
+#[clap(override_usage("<command>"), disable_colored_help(true))]
 pub enum ChatCommand {
     /// Acknowledge a notification
     #[clap(alias = "ack")]
@@ -138,7 +139,7 @@ impl FromStr for IdentifierCli {
 
 /// Command sent in a Zulip stream after `@**triagebot**`.
 #[derive(clap::Parser, Debug)]
-#[clap(override_usage = "`@triagebot <command>`")]
+#[clap(override_usage("`@triagebot <command>`"), disable_colored_help(true))]
 pub enum StreamCommand {
     /// End the current topic.
     #[clap(alias = "await")]
@@ -157,3 +158,12 @@ pub enum StreamCommand {
     /// Update docs
     DocsUpdate,
 }
+
+/// Helper function to parse CLI arguments without any colored help or error output.
+pub fn parse_no_color<'a, T: Parser, I: Iterator<Item = &'a str>>(input: I) -> anyhow::Result<T> {
+    let matches = T::command()
+        .color(ColorChoice::Never)
+        .try_get_matches_from(input)?;
+    let value = T::from_arg_matches(&matches)?;
+    Ok(value)
+}